Overhaul makePgConfig and related interfaces #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ration:
- `GraphileBuild.GraphileResolverContext` renamed to `Grafast.Context`
- `GraphileConfig.GraphQLRequestContext` renamed to `Grafast.RequestContext`
- `Grafast.PgDatabaseAdaptorOptions` renaed to `GraphileConfig.PgDatabaseAdaptorOptions`
- `@dataplan/pg/adaptors/node-postgres` is now `@dataplan/pg/adaptors/pg` due to the bizarre naming of PostgreSQL clients on npm - we've decided to use the module name as the unique identifier
- `makePgConfigs`:
- is now `makePgConfig` (singular) - so you'll need to wrap it in an array where you use it
- no longer exported by `@dataplan/pg` (because it depended on `pg`) - instead each adaptor exposes this helper - so import from `@dataplan/pg/adaptors/node-postgres`
- accepts an object parameter containing `{connectionString, schemas, superuserConnectionString}`, rather than multiple string parameters
- `postgraphile` CLI will now try and respect the adaptor stated in your preset when overriding connection arguments
- Removed `Grafast.RequestContext.httpRequest` and instead use `Grafast.RequestContext.node.req/res`; all server adaptors should implement this if appropriate
benjie
force-pushed
the
postgres-adaptor
branch
from
ff8af89
to
ee7eaa1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨 Breaking changes around types and postgres configuration:
GraphileBuild.GraphileResolverContextrenamed toGrafast.ContextGraphileConfig.GraphQLRequestContextrenamed toGrafast.RequestContextGrafast.PgDatabaseAdaptorOptionsrenaed toGraphileConfig.PgDatabaseAdaptorOptions@dataplan/pg/adaptors/node-postgresis now@dataplan/pg/adaptors/pgdue tothe bizarre naming of PostgreSQL clients on npm - we've decided to use the
module name as the unique identifier
makePgConfigs:makePgConfig(singular) - so you'll need to wrap it in an arraywhere you use it
@dataplan/pg(because it depended onpg) - insteadeach adaptor exposes this helper - so import from
@dataplan/pg/adaptors/node-postgres{connectionString, schemas, superuserConnectionString}, rather thanmultiple string parameters
postgraphileCLI will now try and respect the adaptor stated in your presetwhen overriding connection arguments
Grafast.RequestContext.httpRequestand instead useGrafast.RequestContext.node.req/res; all server adaptors should implementthis if appropriate