Resolve issues around plugin ordering; add more build hooks #233
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously calling
resolvePresets([preset])
(even if you threw away the result) could result in future use of thepreset
having different plugin ordering. This was due to a bug in the sorting algorithm that caused mutation of the plugin's declaredbefore
/after
/provides
- this is now accomplished in an immutable way.Once resolved, this revealed a number of other issues related to plugin ordering:
One major feature in this PR is that we now have the
GraphQLObjectType_fields_field_args_arg
andGraphQLInterfaceType_fields_field_args_arg
hooks and they are used to process every field arg. The plugins that were manipulating individual args (rather than adding them) have been ported to use these hooks, and this should eradicate another class of plugin ordering bugs (it also simplified the code in these places).