Add extensions.pg to proc resources; RENAME EVERYTHING #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kes it easier for plugins to hook them).
The term 'source' was overloaded, and 'configs' was too vague, and
'databaseName' was misleading, and 'source' behaviours actually applied to
resources, and more. So, we've renamed lots of things as part of the API
stabilization work. You're probably only affected by the first 2 bullet points.
- `pgConfigs` -> `pgServices` (also applies to related `pgConfig` terms such as `makePgConfig` -> `makePgService`, `MakePgConfigOptions` -> `MakePgServiceOptions`, etc) - see your `graphile.config.ts` or equivalent file
- All `*:source:*` behaviors are now `*:resource:*` behaviors (use regexp `/:source\b|\bsource:[a-z$]/` to find the places that need updating)
- `PgDatabaseConfiguration` -> `PgServiceConfiguration`
- `databaseName` -> `serviceName` (because it's not the name of the database, it's the name of the `pgServices` (which was `pgConfigs`) entry)
- `PgResourceConfig::source` -> `PgResourceConfig.from` ('source' is overloaded, so use a more direct term)
- `PgResource::source` -> `PgResource.from`
- `PgSelectPlanJoin::source` -> `PgSelectPlanJoin.from`
- `helpers.pgIntrospection.getDatabase` -> `helpers.pgIntrospection.getService`
- `helpers.pgIntrospection.getExecutorForDatabase` -> `helpers.pgIntrospection.getExecutorForService`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
opPlan->operationPlanthroughout (internally).Add extensions.pg to Postgres function resources (makes it easier for plugins to
hook them).
🚨 RENAME ALL THE THINGS
The term 'source' was overloaded, and 'configs' was too vague, and
'databaseName' was misleading, and 'source' behaviours actually applied to
resources, and more. So, we've renamed lots of things as part of the API
stabilization work. You're probably only affected by the first 2 bullet points.
pgConfigs->pgServices(also applies to relatedpgConfigterms such asmakePgConfig->makePgService,MakePgConfigOptions->MakePgServiceOptions, etc) - see yourgraphile.config.tsor equivalentfile
*:source:*behaviors are now*:resource:*behaviors (use regexp/:source\b|\bsource:[a-z$]/to find the places that need updating)PgDatabaseConfiguration->PgServiceConfigurationdatabaseName->serviceName(because it's not the name of the database,it's the name of the
pgServices(which waspgConfigs) entry)PgResourceConfig::source->PgResourceConfig.from('source' is overloaded,so use a more direct term)
PgResource::source->PgResource.fromPgSelectPlanJoin::source->PgSelectPlanJoin.fromhelpers.pgIntrospection.getDatabase->helpers.pgIntrospection.getServicehelpers.pgIntrospection.getExecutorForDatabase->helpers.pgIntrospection.getExecutorForService