Add Node interface to mode=single/relational interfaces #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…we've been facing when optimizing.
…nterface if the table has a PK. 🚨 `@interface mode=union` no longer gets `Node` interface unless you also add `@behavior node`.
benjie
force-pushed
the
interface-node-id
branch
from
b69fd98
to
196e5c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
Nodeinterface to@interface mode:single/@interface mode:relationalif they have primary key - adds to both the interface and the types. Fixes graphile/crystal#1740If you were using
@interface mode:unionthen you'll need to add@behavior nodeto the interface if you want it to have theNodeinterface still (this PR removes that).