Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable insert/update/delete on polymorphic tables for now #459

Merged
merged 3 commits into from
Aug 9, 2023

Conversation

benjie
Copy link
Member

@benjie benjie commented Aug 9, 2023

Mutations were already disabled for @interface mode:single and for the root table of @interface mode:relational but not for the relational subtables. This disables for the relational subtables (as should always have been the case). Arguably a breaking change, but we're not classing it as such since the vast majority of these mutations don't work anyway.

@benjie benjie added this to the V5 RC milestone Aug 9, 2023
@benjie benjie merged commit e1070e1 into main Aug 9, 2023
1 check passed
@benjie benjie deleted the disable-mutations-for-polymorphic-types branch August 9, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

1 participant