Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintainers wanted #53

Open
benjreinhart opened this issue Aug 12, 2017 · 5 comments
Open

Maintainers wanted #53

benjreinhart opened this issue Aug 12, 2017 · 5 comments

Comments

@benjreinhart
Copy link
Owner

I am not currently working in react native regularly, so this project is not a priority for me. However, there is a fair amount of interest around this project so I'd be happy to consider handing the project over to someone who is capable and interested in maintaining it.

@MrHubble
Copy link

@benjreinhart Thanks for creating react-native-aws3 in the first place. It has helped me immensely with my first React Native app.

I'm happy to help with closing stale issues and other similar tasks.

However, is there still a need for this library over just using the default AWS SDK for JavaScript?

As discussed in another issue I had to use the the default aws-sdk library to put with a buffer body rather than post with a file object (POST as used by react-native-aws3 requires a file object, whereas S3 PUT does not).

I also just discovered that we can report the progress with aws-sdk, ie:

var request = s3.putObject(params);
request.on('httpUploadProgress', function (progress) {
  console.log(progress.loaded + " of " + progress.total + " bytes");
});
request.send();

I'm just trying to understand the need to maintain react-native-aws3 as it's helped me greatly and I would like to help maintain it in some way if it still fills a need by the community.

@sibelius
Copy link

@MrHubble this is not addressed yet aws/aws-sdk-js#1595

But https://github.com/awslabs/aws-sdk-react-native looks promising

@benjreinhart
Copy link
Owner Author

@MrHubble sadly, I think you're right. I originally started this because I did not want native dependencies and I wanted a simple interface. At the time at least, the aws sdk was confusing, bloated and required native dependencies. I have not looked at it in over a year, so not sure of the current state.

There is so much more that could be done with this library. I built it to support my needs and then I ended up moving on from my RN app and so this library has been relatively unmaintained since then.

If there is a version of the aws sdk which does not require native dependencies, then I would think this library no longer has any advantages and likely lacks a ton of functionality found in the sdk.

@drews256
Copy link

@benjreinhart What would you think about making a note about this in the Readme? Or pointing people towards AWS Amplify or the AWS JS SDK?

@edoantonioco
Copy link

This library is still needed. The other available options all require linking, which make it not suitable for Expo apps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants