Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About WSconv2d #7

Open
fancyshun opened this issue Sep 9, 2021 · 3 comments
Open

About WSconv2d #7

fancyshun opened this issue Sep 9, 2021 · 3 comments
Assignees

Comments

@fancyshun
Copy link

I see the authoe's code, I find his WSconv2d pad_mod is 'same'. Pytorch's conv2d dono't have pad_mode, and I think your padding should greater 0, but I find your padding always be 0. I want to know why?

I see you train.py your learning rate is constant, why?
Thank you!

@benjs benjs self-assigned this Sep 9, 2021
@benjs
Copy link
Owner

benjs commented Sep 9, 2021

You are right, on first sight, the Stem layers need an additional padding='1' (all convolutions with kernel size 3).
I will take a closer look soon.

It is constant, because I did not implement something fancier yet. What do you think it should be?

Thank you!

@fancyshun
Copy link
Author

You are right, on first sight, the Stem layers need an additional padding='1' (all convolutions with kernel size 3).
I will take a closer look soon.

It is constant, because I did not implement something fancier yet. What do you think it should be?

Thank you!

when kernel size is 3, padding should be different, because stride is 1 or 2.
I see the author's code learning rate is changed by warm up cosine decay.
I also want to know if I train with multiple gpus, how to change batch size.

@benjs
Copy link
Owner

benjs commented Sep 9, 2021

This repo does not support multi gpu training, you can only reuse the model code for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants