Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getip function has trailing newline #43

Closed
benknoble opened this issue Jul 17, 2017 · 0 comments
Closed

getip function has trailing newline #43

benknoble opened this issue Jul 17, 2017 · 0 comments
Assignees
Milestone

Comments

@benknoble
Copy link
Owner

Current behavior

${PS1} $ getip 
xx.x.x.xx
                     # spaces added to show where newline is

Desired behavior

${PS1} $ getip 
xx.x.x.xx

Fix

Remove echo from function definition:

getip () 
{ 
    ipconfig getifaddr en0;
    # remove this # echo
}
@benknoble benknoble added this to the Version 1.1 milestone Jul 17, 2017
@benknoble benknoble self-assigned this Jul 17, 2017
@benknoble benknoble modified the milestones: Version 1.1, Version 1.4 Jul 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant