[eslint] increase severity of rules; eslint --quiet --fix

import-js · Sep 16, 2019 · 0964fee · 0964fee
1 parent 7b96fa1
commit 0964fee
Show file tree

Hide file tree

Showing 30 changed files with 77 additions and 140 deletions.
diff --git a/.eslintrc.yml b/.eslintrc.yml
@@ -24,6 +24,7 @@ rules:
     - 2
     - single
     - allowTemplateLiterals: true
+      avoidEscape: true
 
   # dog fooding
   import/no-extraneous-dependencies: "error"

diff --git a/config/.eslintrc.yml b/config/.eslintrc.yml
diff --git a/config/errors.js b/config/errors.js
@@ -9,6 +9,6 @@ module.exports = {
          , 'import/named': 2
          , 'import/namespace': 2
          , 'import/default': 2
-         , 'import/export': 2
-         }
+         , 'import/export': 2,
+         },
 }
diff --git a/config/recommended.js b/config/recommended.js
@@ -16,7 +16,7 @@ module.exports = {
     // red flags (thus, warnings)
     'import/no-named-as-default': 'warn',
     'import/no-named-as-default-member': 'warn',
-    'import/no-duplicates': 'warn'
+    'import/no-duplicates': 'warn',
   },
 
   // need all these for parsing dependencies (even if _your_ code doesn't need

diff --git a/config/stage-0.js b/config/stage-0.js
@@ -8,5 +8,5 @@ module.exports = {
   plugins: ['import'],
   rules: {
     'import/no-deprecated': 1,
-  }
+  },
 }
diff --git a/config/typescript.js b/config/typescript.js
@@ -2,20 +2,20 @@
  * Adds `.jsx`, `.ts` and `.tsx` as an extension, and enables JSX/TSX parsing.
  */
 
-var allExtensions = ['.ts', '.tsx', '.d.ts', '.js', '.jsx'];
+var allExtensions = ['.ts', '.tsx', '.d.ts', '.js', '.jsx']
 
 module.exports = {
 
   settings: {
     'import/extensions': allExtensions,
     'import/parsers': {
-      '@typescript-eslint/parser': ['.ts', '.tsx', '.d.ts']
+      '@typescript-eslint/parser': ['.ts', '.tsx', '.d.ts'],
     },
     'import/resolver': {
       'node': {
-        'extensions': allExtensions
-      }
-    }
-  }
+        'extensions': allExtensions,
+      },
+    },
+  },
 
 }
diff --git a/memo-parser/.eslintrc.yml b/memo-parser/.eslintrc.yml
@@ -1,14 +1,3 @@
 ---
 rules:
-  semi: [1, 'never']
-  comma-dangle: [1, 'always-multiline']
-  no-console: 1
-  no-extra-semi: 1
-  no-useless-escape: 1
-  quotes:
-    - 1
-    - single
-    - allowTemplateLiterals: true
-      avoidEscape: true
-  import/default: 1
   import/no-extraneous-dependencies: 1
diff --git a/memo-parser/index.js b/memo-parser/index.js
@@ -1,4 +1,4 @@
-"use strict"
+'use strict'
 
 const crypto = require('crypto')
     , moduleRequire = require('eslint-module-utils/module-require').default
@@ -20,7 +20,7 @@ exports.parse = function parse(content, options) {
   options = Object.assign({}, options, parserOptions)
 
   if (!options.filePath) {
-    throw new Error("no file path provided!")
+    throw new Error('no file path provided!')
   }
 
   const keyHash = crypto.createHash('sha256')

diff --git a/resolvers/.eslintrc.yml b/resolvers/.eslintrc.yml
@@ -1,16 +1,3 @@
 ---
 env:
   es6: false
-rules:
-  semi: [1, 'never']
-  comma-dangle: [1, 'always-multiline']
-  no-console: 1
-  no-extra-semi: 1
-  no-useless-escape: 1
-  quotes:
-    - 1
-    - single
-    - allowTemplateLiterals: true
-      avoidEscape: true
-  import/default: 1
-  import/no-extraneous-dependencies: 1
diff --git a/resolvers/webpack/test/config.js b/resolvers/webpack/test/config.js
@@ -119,8 +119,8 @@ describe("config", function () {
     var settings = {
       config: require(path.join(__dirname, './files/webpack.function.config.js')),
       argv: {
-        mode: 'test'
-      }
+        mode: 'test',
+      },
     }
 
     expect(resolve('baz', file, settings)).to.have.property('path')
@@ -130,7 +130,7 @@ describe("config", function () {
   it('passes a default empty argv object to config when it is a function', function() {
     var settings = {
       config: require(path.join(__dirname, './files/webpack.function.config.js')),
-      argv: undefined
+      argv: undefined,
     }
 
     expect(function () { resolve('baz', file, settings) }).to.not.throw(Error)

diff --git a/tests/.eslintrc.yml b/tests/.eslintrc.yml
@@ -4,17 +4,5 @@ parserOptions:
 env:
   mocha: true
 rules:
-  no-unused-expressions: 0
   max-len: 0
-  semi: [1, 'never']
-  comma-dangle: [1, 'always-multiline']
-  no-console: 1
-  no-extra-semi: 1
-  no-useless-escape: 1
-  quotes:
-    - 1
-    - single
-    - allowTemplateLiterals: true
-      avoidEscape: true
-  import/default: 1
-  import/no-extraneous-dependencies: 1
+  import/default: 0
diff --git a/tests/src/core/importType.js b/tests/src/core/importType.js
@@ -43,12 +43,12 @@ describe('importType(name)', function () {
   })
 
   it("should return 'internal' for non-builtins resolved outside of node_modules", function () {
-    const pathContext = testContext({ "import/resolver": { node: { paths: [pathToTestFiles] } } })
+    const pathContext = testContext({ 'import/resolver': { node: { paths: [pathToTestFiles] } } })
     expect(importType('importType', pathContext)).to.equal('internal')
   })
 
   it.skip("should return 'internal' for scoped packages resolved outside of node_modules", function () {
-    const pathContext = testContext({ "import/resolver": { node: { paths: [pathToTestFiles] } } })
+    const pathContext = testContext({ 'import/resolver': { node: { paths: [pathToTestFiles] } } })
     expect(importType('@importType/index', pathContext)).to.equal('internal')
   })
 

diff --git a/tests/src/core/resolve.js b/tests/src/core/resolve.js
@@ -111,8 +111,8 @@ describe('resolve', function () {
   })
 
   it('reports loaded resolver with invalid interface', function () {
-    const resolverName = './foo-bar-resolver-invalid';
-    const testContext = utils.testContext({ 'import/resolver': resolverName });
+    const resolverName = './foo-bar-resolver-invalid'
+    const testContext = utils.testContext({ 'import/resolver': resolverName })
     const testContextReports = []
     testContext.report = function (reportInfo) {
       testContextReports.push(reportInfo)

diff --git a/tests/src/rules/exports-last.js b/tests/src/rules/exports-last.js
@@ -8,8 +8,8 @@ const ruleTester = new RuleTester()
 const error = type => ({
   ruleId: 'exports-last',
   message: 'Export statements should appear at the end of the file',
-  type
-});
+  type,
+})
 
 ruleTester.run('exports-last', rule, {
   valid: [

diff --git a/tests/src/rules/first.js b/tests/src/rules/first.js
@@ -22,7 +22,7 @@ ruleTester.run('first', rule, {
          , errors: 1
          , output: "import { x } from './foo';\
                   import { y } from './bar';\
-                  export { x };"
+                  export { x };",
          })
   , test({ code: "import { x } from './foo';\
                   export { x };\
@@ -32,19 +32,19 @@ ruleTester.run('first', rule, {
          , output: "import { x } from './foo';\
                   import { y } from './bar';\
                   import { z } from './baz';\
-                  export { x };"
+                  export { x };",
          })
   , test({ code: "import { x } from './foo'; import { y } from 'bar'"
          , options: ['absolute-first']
-         , errors: 1
+         , errors: 1,
          })
   , test({ code: "import { x } from 'foo';\
                   'use directive';\
                   import { y } from 'bar';"
          , errors: 1
          , output: "import { x } from 'foo';\
                   import { y } from 'bar';\
-                  'use directive';"
+                  'use directive';",
          })
   , test({ code: "var a = 1;\
                   import { y } from './bar';\
@@ -56,12 +56,12 @@ ruleTester.run('first', rule, {
                   var a = 1;\
                   if (true) { x() };\
                   import { x } from './foo';\
-                  import { z } from './baz';"
+                  import { z } from './baz';",
   })
   , test({ code: "if (true) { console.log(1) }import a from 'b'"
          , errors: 1
-         , output: "import a from 'b'\nif (true) { console.log(1) }"
+         , output: "import a from 'b'\nif (true) { console.log(1) }",
   })
   ,
-  ]
+  ],
 })
diff --git a/tests/src/rules/named.js b/tests/src/rules/named.js
@@ -197,7 +197,7 @@ ruleTester.run('named', rule, {
     test({
       code: 'import { baz } from "./broken-trampoline"',
       parser: require.resolve('babel-eslint'),
-      errors: ["baz not found via broken-trampoline.js -> named-exports.js"],
+      errors: ['baz not found via broken-trampoline.js -> named-exports.js'],
     }),
 
     // parse errors

diff --git a/tests/src/rules/no-deprecated.js b/tests/src/rules/no-deprecated.js
@@ -15,16 +15,16 @@ ruleTester.run('no-deprecated', rule, {
 
     test({
       code: "import { fn } from './deprecated'",
-      settings: { 'import/docstyle': ['tomdoc'] }
+      settings: { 'import/docstyle': ['tomdoc'] },
     }),
 
     test({
       code: "import { fine } from './tomdoc-deprecated'",
-      settings: { 'import/docstyle': ['tomdoc'] }
+      settings: { 'import/docstyle': ['tomdoc'] },
     }),
     test({
       code: "import { _undocumented } from './tomdoc-deprecated'",
-      settings: { 'import/docstyle': ['tomdoc'] }
+      settings: { 'import/docstyle': ['tomdoc'] },
     }),
 
     // naked namespace is fine
@@ -70,7 +70,7 @@ ruleTester.run('no-deprecated', rule, {
     test({
       code: "import { fn } from './tomdoc-deprecated'",
       settings: { 'import/docstyle': ['tomdoc'] },
-      errors: ["Deprecated: This function is terrible."],
+      errors: ['Deprecated: This function is terrible.'],
     }),
 
     test({

diff --git a/tests/src/rules/no-restricted-paths.js b/tests/src/rules/no-restricted-paths.js
@@ -37,14 +37,14 @@ ruleTester.run('no-restricted-paths', rule, {
       filename: testFilePath('./restricted-paths/client/a.js'),
         options: [ {
           zones: [ { target: './tests/files/restricted-paths/client', from: './tests/files/restricted-paths/server' } ],
-        } ], }),
+        } ] }),
 
     // no config
     test({ code: 'require("../server/b.js")' }),
     test({ code: 'import b from "../server/b.js"' }),
 
     // builtin (ignore)
-    test({ code: 'require("os")' })
+    test({ code: 'require("os")' }),
   ],
 
   invalid: [

diff --git a/tests/src/rules/no-unassigned-import.js b/tests/src/rules/no-unassigned-import.js
@@ -8,7 +8,7 @@ const ruleTester = new RuleTester()
 
 const error = {
   ruleId: 'no-unassigned-import',
-  message: 'Imported module should be assigned'
+  message: 'Imported module should be assigned',
 }
 
 ruleTester.run('no-unassigned-import', rule, {

diff --git a/tests/src/rules/no-unresolved.js b/tests/src/rules/no-unresolved.js
@@ -302,34 +302,34 @@ ruleTester.run('no-unresolved ignore list', rule, {
   valid: [
     test({
       code: 'import "./malformed.js"',
-      options: [{ ignore: ['\.png$', '\.gif$']}],
+      options: [{ ignore: ['.png$', '.gif$']}],
     }),
     test({
       code: 'import "./test.giffy"',
-      options: [{ ignore: ['\.png$', '\.gif$']}],
+      options: [{ ignore: ['.png$', '.gif$']}],
     }),
 
     test({
       code: 'import "./test.gif"',
-      options: [{ ignore: ['\.png$', '\.gif$']}],
+      options: [{ ignore: ['.png$', '.gif$']}],
     }),
 
     test({
       code: 'import "./test.png"',
-      options: [{ ignore: ['\.png$', '\.gif$']}],
+      options: [{ ignore: ['.png$', '.gif$']}],
     }),
   ],
 
   invalid:[
     test({
       code: 'import "./test.gif"',
-      options: [{ ignore: ['\.png$']}],
+      options: [{ ignore: ['.png$']}],
       errors: [ "Unable to resolve path to module './test.gif'." ],
     }),
 
     test({
       code: 'import "./test.png"',
-      options: [{ ignore: ['\.gif$']}],
+      options: [{ ignore: ['.gif$']}],
       errors: [ "Unable to resolve path to module './test.png'." ],
     }),
   ],