ignore magic AMD modules (fixes #129)

import-js · Nov 29, 2015 · 633205c · 633205c
1 parent f786e88
commit 633205c
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 4 deletions.
diff --git a/src/rules/no-unresolved.js b/src/rules/no-unresolved.js
@@ -47,6 +47,9 @@ module.exports = function (context) {
       if (element.type !== 'Literal') continue
       if (typeof element.value !== 'string') continue
 
+      if (element.value === 'require' ||
+          element.value === 'exports') continue // magic modules: http://git.io/vByan
+
       checkSourceValue(element)
     }
   }

diff --git a/tests/files/module/index.js → tests/files/test-module/index.js b/tests/files/module/index.js → tests/files/test-module/index.js
diff --git a/tests/src/rules/named.js b/tests/src/rules/named.js
@@ -39,7 +39,7 @@ ruleTester.run('named', rule, {
     test({ code: 'import { foo } from "crypto"' }),
     test({ code: 'import { zoob } from "a"' }),
 
-    test({ code: 'import { someThing } from "./module"' }),
+    test({ code: 'import { someThing } from "./test-module"' }),
 
     // node_modules/a only exports 'foo', should be ignored though
     test({ code: 'import { zoob } from "a"' }),
@@ -91,8 +91,8 @@ ruleTester.run('named', rule, {
          , settings: { 'import/ignore': [] }
          , errors: [ error('zoob', 'a') ] }),
 
-    test({ code: 'import { somethingElse } from "./module"'
-         , errors: [ error('somethingElse', './module') ] }),
+    test({ code: 'import { somethingElse } from "./test-module"'
+         , errors: [ error('somethingElse', './test-module') ] }),
 
     test({code: 'import {a, b, d} from "./common"',
       errors: [ error('a', './common')

diff --git a/tests/src/rules/no-unresolved.js b/tests/src/rules/no-unresolved.js
@@ -23,7 +23,7 @@ function runResolverTests(resolver) {
     valid: [
       rest({ code: 'import foo from "./bar";' }),
       rest({ code: "import bar from './bar.js';" }),
-      rest({ code: "import {someThing} from './module';" }),
+      rest({ code: "import {someThing} from './test-module';" }),
       rest({ code: "import fs from 'fs';" }),
 
       rest({ code: 'import * as foo from "a"' }),
@@ -55,6 +55,10 @@ function runResolverTests(resolver) {
            , options: [{ amd: true }]}),
       rest({ code: 'require(["./does-not-exist"], function (bar) {})'
            , options: [{ amd: false }]}),
+      // magic modules: http://git.io/vByan
+      rest({ code: 'define(["require", "exports", "module"], function (r, e, m) { })'
+           , options: [{ amd: true }]}),
+
       // don't validate without callback param
       rest({ code: 'require(["./does-not-exist"])'
            , options: [{ amd: true }]}),