Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefer-default-export False Positive #1455

Closed
j-a-y-h opened this issue Aug 18, 2019 · 5 comments · Fixed by #1506
Closed

prefer-default-export False Positive #1455

j-a-y-h opened this issue Aug 18, 2019 · 5 comments · Fixed by #1506

Comments

@j-a-y-h
Copy link

j-a-y-h commented Aug 18, 2019

Description
eslint-plugin-import v2.18.2 throws an error (error Prefer default export import/prefer-default-export) when there are multiple export statements in a typescript file. (this is probably not limited to typescript)

Expected Results
eslint-plugin-import v2.18.1 does not throw this error. This behavior aligns with the example page: prefer-default-export

Basic Example:

export interface SubmitHandler {}
export function anything() {}
// error  Prefer default export  import/prefer-default-export
@j-a-y-h j-a-y-h changed the title Prefer Default Export False Positive prefer-default-export False Positive Aug 18, 2019
@xwatkins
Copy link

Experiencing the same issue with 2.18.1 and above but not with 2.18.0.

@soullivaneuh

This comment has been minimized.

@ljharb

This comment has been minimized.

@soullivaneuh

This comment has been minimized.

@ljharb

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

4 participants