Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recommended shared config #402

Closed
benmosher opened this issue Jun 30, 2016 · 2 comments
Closed

recommended shared config #402

benmosher opened this issue Jun 30, 2016 · 2 comments
Milestone

Comments

@benmosher
Copy link
Member

benmosher commented Jun 30, 2016

Seems to be a common pattern amongst plugins.

Probably should be a combo of errors and warnings?

Also: see #416, probably want the following parser options, too:

  parserOptions: {
    sourceType: 'module',
    ecmaVersion: 6,
    ecmaFeatures: { experimentalObjectRestSpread: true, jsx: true },
  },

@jfmengels this is probably another way to steer users towards static analysis. I have felt like the errors and warnings shared configs were not named clearly, anyway. Probably will keep them since it doesn't hurt, but merge them (or maybe just take errors) for the recommended version.

@benmosher benmosher added this to the 2.0.0 milestone Jul 1, 2016
benmosher added a commit that referenced this issue Jul 7, 2016
benmosher added a commit that referenced this issue Jul 7, 2016
@benmosher
Copy link
Member Author

@jfmengels would love your feedback on what I put together for this

@jfmengels
Copy link
Collaborator

I left some comments in the commit. I'd be happy to discuss it more if you want to. Either in a new issue or in the commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants