Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eslint-module-utils tests #865

Merged
merged 17 commits into from Jun 22, 2017
Merged

eslint-module-utils tests #865

merged 17 commits into from Jun 22, 2017

Conversation

sompylasar
Copy link
Contributor

No description provided.

@sompylasar
eslint-module-utils: filePath in parserOptions
b4d75c8 
Refs import-js#839
@sompylasar
eslint-module-utils: Add tests for parserOptions
3544c0f 
Refs import-js#839
@sompylasar
eslint-module-utils: Reverted manual version bumps.
7712ce1 
Refs import-js#839
@sompylasar
Merge branch 'benmosher/master' into patch-2
d4246fb 
* benmosher/master:
  update CI to build on Node 6+7 (import-js#846)
  changelog update for 2.3.0
@sompylasar
Add sinon, replace eslint-module-utils test spy with sinon.spy
d0007f2
@sompylasar
Fix CHANGELOG merge error
7ac5e8f
@sompylasar
eslint-module-utils: Add more tests for parse (coverage 100%)
d397b9b
@sompylasar
eslint-module-utils: In tests move require stub parser to the top.
5732742
@sompylasar
Merge commit '3c46d308ccb462a52554257c49c374045d1a6cf7' into file_pat…
60b524b 
…h_in_parser_options

* commit '3c46d308ccb462a52554257c49c374045d1a6cf7':
  rollback utils dependency to 2.0.0
  add yank note to utils change log
  add yanking note to root change log
  Upgrade debug version of eslint-module-utils (import-js#844)
  remove obsolete dad joke
  update utils changelog
  bump eslint-module-utils to v2.1.0
  bump v2.4.0
  fix typos, enforce type of array of strings in allow option
  update CHANGELOG.md
  eslint-module-utils: filePath in parserOptions (import-js#840)
  write doc, add two more tests
  add allow glob for rule no-unassigned-import, fix import-js#671

# Conflicts:
#	utils/CHANGELOG.md
@sompylasar
eslint-module-utils: Add tests for hash utils
17d2ee9
@sompylasar
eslint-module-utils: Add tests for resolver versions
a0012f8
@sompylasar
eslint-module-utils: Unified test specs names to not use 'should' word
f65c263
@coveralls
Copy link

coveralls commented Jun 4, 2017 •
edited

Coverage Status

Coverage increased (+0.5%) to 95.664% when pulling f65c263 on sompylasar:eslint-module-utils_tests into 3c46d30 on benmosher:master.

@coveralls
Copy link

coveralls commented Jun 5, 2017 •
edited

Coverage Status

Coverage increased (+0.5%) to 95.702% when pulling 06695c4 on sompylasar:eslint-module-utils_tests into 3c46d30 on benmosher:master.

@coveralls
Copy link

coveralls commented Jun 5, 2017 •
edited

Coverage Status

Coverage increased (+0.8%) to 95.909% when pulling 3b4cb47 on sompylasar:eslint-module-utils_tests into 3c46d30 on benmosher:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 95.909% when pulling 3b4cb47 on sompylasar:eslint-module-utils_tests into 3c46d30 on benmosher:master.

@coveralls
Copy link

coveralls commented Jun 5, 2017 •
edited

Coverage Status

Coverage increased (+0.8%) to 95.963% when pulling 314ead8 on sompylasar:eslint-module-utils_tests into 3c46d30 on benmosher:master.

@coveralls
Copy link

coveralls commented Jun 5, 2017 •
edited

Coverage Status

Coverage increased (+0.8%) to 95.963% when pulling 314ead8 on sompylasar:eslint-module-utils_tests into 3c46d30 on benmosher:master.

ljharb
ljharb reviewed Jun 5, 2017
View reviewed changes
CHANGELOG.md
@@ -144,8 +145,7 @@ Yanked due to critical issue in eslint-module-utils with cache key resulting fro
- Something horrible happened during `npm prepublish` of 1.10.1.
Several `rm -rf node_modules && npm i` and `gulp clean && npm prepublish`s later, it is rebuilt and republished as 1.10.2. Thanks [@rhettlivingston] for noticing and reporting!

## [1.10.1] - 2016-07-02 [
ED]
## [1.10.1] - 2016-07-02 [YANKED]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use "unpublished" here; "yanked" is an idiom and needlessly casual.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ljharb I don't mind, but that's @benmosher's, I just fixed the typo.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I didn't realize it was an existing pattern. Nvm then.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw, I thought YANKED was a bit weird also, but I used it because it was explicitly defined on http://keepachangelog.com/ when I started it. I'm fine to move to UNPUBLISHED if that's generally well-understood

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 94.78% when pulling 117717f on sompylasar:eslint-module-utils_tests into 3c46d30 on benmosher:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 94.78% when pulling 117717f on sompylasar:eslint-module-utils_tests into 3c46d30 on benmosher:master.

@benmosher
Copy link
Member

This is great, thanks! appveyor failure was some nonsense so LGTM

@benmosher benmosher merged commit 14c501e into import-js:master Jun 22, 2017
@renovate-bot renovate-bot mentioned this pull request Jun 23, 2017
Merged
@renovate renovate bot mentioned this pull request Jun 23, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb left review comments

@benmosher benmosher benmosher left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sompylasar @coveralls @benmosher @ljharb