New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use resolved package name #1119
base: main
Are you sure you want to change the base?
Conversation
Should fix import-js#496
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test case that would have failed without this change?
Assume folder with packages is node_modules and take part of path after last node_modules
@ljharb I've added the test that would have failed without fix in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little nervous about letting node_modules
sneak into a rule proper, though to be fair no-extra-deps
is a Node-specific rule.
I'll try to come back around to this in a second pass after letting it cook in my brain for a little bit.
@arcanis i'm intending to merge this soon, does it need any changes to avoid causing berry problems? |
From the look of it it should be compatible in most cases, since we store packages inside a standalone
One caveat however: we cannot do that when people use the {
"dependencies": {
"foo": "link:./foo"
}
} You'd have |
Should fix #496