Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: false positives for typescript type + value export #1319

Merged
merged 1 commit into from Apr 12, 2019

Conversation

Projects
None yet
3 participants
@bradzacher
Copy link
Contributor

bradzacher commented Apr 12, 2019

Fixes #1318

@ljharb

This comment has been minimized.

Copy link
Collaborator

ljharb commented Apr 12, 2019

This seems like it might overlap with #923?

@ljharb ljharb added the typescript label Apr 12, 2019

@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 12, 2019

Coverage Status

Coverage decreased (-0.1%) to 97.764% when pulling abb354a on bradzacher:export-ts-type-value into 70a59fe on benmosher:master.

@bradzacher

This comment has been minimized.

Copy link
Contributor Author

bradzacher commented Apr 12, 2019

@ljharb to prevent double commenting - #1318 (comment)

if ([
'TSTypeAliasDeclaration',
'TSInterfaceDeclaration',
].includes(node.declaration.type)) {

This comment has been minimized.

Copy link
@ljharb

ljharb Apr 12, 2019

Collaborator

includes isn't available on node 4; we'll need to add the array-includes package here.

export const Foo = 1;
export type Foo = number;
`,
...parserConfig,

This comment has been minimized.

Copy link
@ljharb

ljharb Apr 12, 2019

Collaborator

also, object spread isn't on node < 8.

@ljharb ljharb force-pushed the bradzacher:export-ts-type-value branch from abb354a to 2098797 Apr 12, 2019

@ljharb

ljharb approved these changes Apr 12, 2019

Copy link
Collaborator

ljharb left a comment

Rebased and fixed.

@ljharb ljharb merged commit 2098797 into benmosher:master Apr 12, 2019

0 of 4 checks passed

continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

ljharb added a commit that referenced this pull request Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.