Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix apparent corner case with `import/no-commonjs` rule #1354

Merged
merged 1 commit into from May 6, 2019

Conversation

Projects
None yet
4 participants
@charlessuh
Copy link

commented May 5, 2019

var x = require("x") will throw an error, but var x; x = require("x") does not.

@charlessuh charlessuh changed the title Assign no commonjs Fix apparent corner case with `import/no-commonjs` rule May 5, 2019

@coveralls

This comment has been minimized.

Copy link

commented May 6, 2019

Coverage Status

Coverage increased (+2.5%) to 97.937% when pulling 5d05134 on charlessuh:assign-no-commonjs into f63dd26 on benmosher:master.

2 similar comments
@coveralls

This comment has been minimized.

Copy link

commented May 6, 2019

Coverage Status

Coverage increased (+2.5%) to 97.937% when pulling 5d05134 on charlessuh:assign-no-commonjs into f63dd26 on benmosher:master.

@coveralls

This comment has been minimized.

Copy link

commented May 6, 2019

Coverage Status

Coverage increased (+2.5%) to 97.937% when pulling 5d05134 on charlessuh:assign-no-commonjs into f63dd26 on benmosher:master.

@coveralls

This comment has been minimized.

Copy link

commented May 6, 2019

Coverage Status

Coverage increased (+2.5%) to 97.937% when pulling 1edbbd0 on charlessuh:assign-no-commonjs into f63dd26 on benmosher:master.

Show resolved Hide resolved tests/src/rules/no-commonjs.js Outdated

@charlessuh charlessuh force-pushed the charlessuh:assign-no-commonjs branch from 5d05134 to 77390d2 May 6, 2019

@ljharb

ljharb approved these changes May 6, 2019

@ljharb ljharb force-pushed the charlessuh:assign-no-commonjs branch from 77390d2 to 1edbbd0 May 6, 2019

@ljharb

This comment has been minimized.

Copy link
Collaborator

commented May 6, 2019

I think this can be called a bugfix, even though it will cause more warnings to be issued.

@ljharb ljharb added the bug label May 6, 2019

@ljharb ljharb merged commit 1edbbd0 into benmosher:master May 6, 2019

2 of 3 checks passed

continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.