Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ExportMap for a merged typescript namespace #1495

Merged
merged 1 commit into from Oct 9, 2019

Conversation

@benmunro
Copy link
Contributor

commented Oct 7, 2019

Fixes a bug where not all of the declarations from multiple declare namespace copies would be merged together when the namespace was assigned as the export. I couldn't see any issue reported for this bug already.

…space

A typescript namespace may be declared multiple times, it is then merged
together and considered to be a single declaration from consuming code.
In the case where a merged namespace is assigned as the export from a
module then the declarations from all the instances of the namespace in
the AST need to be considered as exported.
@coveralls

This comment has been minimized.

Copy link

commented Oct 7, 2019

Coverage Status

Coverage decreased (-0.1%) to 96.341% when pulling c14c9bd on benmunro:master into d030d8e on benmosher:master.

@coveralls

This comment has been minimized.

Copy link

commented Oct 7, 2019

Coverage Status

Coverage increased (+0.8%) to 96.143% when pulling 6b81bd9 on benmunro:master into 5e143b2 on benmosher:master.

5 similar comments
@coveralls

This comment has been minimized.

Copy link

commented Oct 7, 2019

Coverage Status

Coverage increased (+0.8%) to 96.143% when pulling 6b81bd9 on benmunro:master into 5e143b2 on benmosher:master.

@coveralls

This comment has been minimized.

Copy link

commented Oct 7, 2019

Coverage Status

Coverage increased (+0.8%) to 96.143% when pulling 6b81bd9 on benmunro:master into 5e143b2 on benmosher:master.

@coveralls

This comment has been minimized.

Copy link

commented Oct 7, 2019

Coverage Status

Coverage increased (+0.8%) to 96.143% when pulling 6b81bd9 on benmunro:master into 5e143b2 on benmosher:master.

@coveralls

This comment has been minimized.

Copy link

commented Oct 7, 2019

Coverage Status

Coverage increased (+0.8%) to 96.143% when pulling 6b81bd9 on benmunro:master into 5e143b2 on benmosher:master.

@coveralls

This comment has been minimized.

Copy link

commented Oct 7, 2019

Coverage Status

Coverage increased (+0.8%) to 96.143% when pulling 6b81bd9 on benmunro:master into 5e143b2 on benmosher:master.

@ljharb ljharb added the typescript label Oct 8, 2019
@ljharb
ljharb approved these changes Oct 8, 2019
@ljharb ljharb force-pushed the benmunro:master branch from 6b81bd9 to c14c9bd Oct 9, 2019
@ljharb ljharb merged commit c14c9bd into benmosher:master Oct 9, 2019
2 of 3 checks passed
2 of 3 checks passed
coverage/coveralls Coverage decreased (-0.3%) to 96.176%
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.