Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash due to export * with no-unused-modules #1496

Open
wants to merge 3 commits into
base: master
from

Conversation

@Taranys
Copy link

commented Oct 8, 2019

fix #1382

After investigating, It comes from this line

if (isIgnored(path, context) || !unambiguous.test(content)) {

In my case, export * from 'redux-starter-kit' is not detected as unambigous and it return null which crash no-unused-modules

I didn't find any good way to test it. I'm looking forward for some advices on how I can test this issue :)

@coveralls

This comment has been minimized.

Copy link

commented Oct 8, 2019

Coverage Status

Coverage increased (+0.7%) to 96.029% when pulling 98a2dcc on Taranys:bug/fix-1382 into 5e143b2 on benmosher:master.

2 similar comments
@coveralls

This comment has been minimized.

Copy link

commented Oct 8, 2019

Coverage Status

Coverage increased (+0.7%) to 96.029% when pulling 98a2dcc on Taranys:bug/fix-1382 into 5e143b2 on benmosher:master.

@coveralls

This comment has been minimized.

Copy link

commented Oct 8, 2019

Coverage Status

Coverage increased (+0.7%) to 96.029% when pulling 98a2dcc on Taranys:bug/fix-1382 into 5e143b2 on benmosher:master.

@coveralls

This comment has been minimized.

Copy link

commented Oct 8, 2019

Coverage Status

Coverage increased (+1.2%) to 96.524% when pulling 337c45c on Taranys:bug/fix-1382 into 5e143b2 on benmosher:master.

Copy link
Collaborator

left a comment

Thanks!

To test it, please add some files in https://github.com/benmosher/eslint-plugin-import/tree/master/tests/files that can reproduce the issue.

src/rules/no-unused-modules.js Outdated Show resolved Hide resolved
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.