Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extensions] Ignore query strings when checking for extensions. #1572

Merged
merged 1 commit into from Jan 1, 2020

Conversation

@pcorpet
Copy link
Contributor

pcorpet commented Dec 15, 2019

Fixes #1567.

Fixes #1567.
@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 15, 2019

Coverage Status

Coverage decreased (-0.1%) to 96.176% when pulling 982493d on pcorpet:query-string-extension into b791ba5 on benmosher:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 15, 2019

Coverage Status

Coverage increased (+0.1%) to 96.367% when pulling e3fa2ce on pcorpet:query-string-extension into 4e8960d on benmosher:master.

3 similar comments
@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 15, 2019

Coverage Status

Coverage increased (+0.1%) to 96.367% when pulling e3fa2ce on pcorpet:query-string-extension into 4e8960d on benmosher:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 15, 2019

Coverage Status

Coverage increased (+0.1%) to 96.367% when pulling e3fa2ce on pcorpet:query-string-extension into 4e8960d on benmosher:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 15, 2019

Coverage Status

Coverage increased (+0.1%) to 96.367% when pulling e3fa2ce on pcorpet:query-string-extension into 4e8960d on benmosher:master.

@ljharb
ljharb approved these changes Jan 1, 2020
Copy link
Collaborator

ljharb left a comment

This looks great!

src/rules/extensions.js Outdated Show resolved Hide resolved
src/rules/extensions.js Outdated Show resolved Hide resolved
@ljharb ljharb force-pushed the pcorpet:query-string-extension branch from 864d99c to 982493d Jan 1, 2020
@ljharb ljharb merged commit 982493d into benmosher:master Jan 1, 2020
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
coverage/coveralls Coverage decreased (-0.1%) to 96.176%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.