Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export: Handle function overloading in '*.d.ts' #1619

Merged
merged 1 commit into from Feb 1, 2020

Conversation

@IvanGoncharov
Copy link
Contributor

IvanGoncharov commented Jan 20, 2020

I'm trying to use this rule to validate *.d.ts files and they contain only TSDeclareFunction and can't contain FunctionDeclaration.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 20, 2020

Coverage Status

Coverage remained the same at 97.838% when pulling bbd166b on IvanGoncharov:master into 4665ec5 on benmosher:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 20, 2020

Coverage Status

Coverage remained the same at 97.837% when pulling d1d1ef6 on IvanGoncharov:master into f84d457 on benmosher:master.

2 similar comments
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 20, 2020

Coverage Status

Coverage remained the same at 97.837% when pulling d1d1ef6 on IvanGoncharov:master into f84d457 on benmosher:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 20, 2020

Coverage Status

Coverage remained the same at 97.837% when pulling d1d1ef6 on IvanGoncharov:master into f84d457 on benmosher:master.

@IvanGoncharov IvanGoncharov requested a review from ljharb Jan 21, 2020
@ljharb ljharb force-pushed the IvanGoncharov:master branch from d1d1ef6 to bbd166b Feb 1, 2020
@ljharb
ljharb approved these changes Feb 1, 2020
@ljharb ljharb added the typescript label Feb 1, 2020
@ljharb ljharb merged commit bbd166b into benmosher:master Feb 1, 2020
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 97.838%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.