Make imports-first treat directives as an exception #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmosher
added a commit
that referenced
this pull request
Apr 22, 2016
|
Just tacked a note into the changelog. Duly noted about a contribution guide, just opened #258 to that end 😄 |
This was referenced Apr 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #255. Per discussion in that issue, directives need to appear at the top of a file in order to be considered directives. This isn't usually a problem because modules remove the need for
'use strict', but we use a custom directive as part of our build system. This PR makesimports-firstunderstand directives and not throw errors when those appear above import statements.cc/ @benmosher, let me know if anything else is needed; I didn't see a contributing file in the repo so not sure what the best practices are.