log a useful error in a module bug arises #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is not the root cause of import-js#767, but it at least makes it possible for folks to figure out real fast what is causing the error. fix import-js#767
ljharb
requested changes
Oct 24, 2017
| try { | ||
| webpackConfig = require(configPath) | ||
| } catch(e) { | ||
| console.log('Error resolving webpackConfig', e) |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
@mattkrick why close this? This is a good change. |
|
just cleaning up some PRs. I no longer use the package |
|
I can't understand no longer linting imports, but I'll try to take this over the finish line if you're not interested in doing so. |
ljharb
approved these changes
Jun 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is not the root cause of #767, but it at least makes it possible for folks to figure out real fast what is causing the error (use log because eslint swallows thrown errors)
fix #767