New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add minimal word length setting #17
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I like the idea. But I have some issues with this:
|
I'll fix the tests. Forgot about those. Possibly, we need to regenerate the board of there are no or not enough solutions |
rspilker
force-pushed
the
minimallength
branch
2 times, most recently
from
October 25, 2018 17:57
d07983c
to
5286101
Compare
The tests are fixed now |
rspilker
force-pushed
the
minimallength
branch
from
October 25, 2018 21:01
5286101
to
4c9e056
Compare
The commits in between are already in master. The only relevant changeset is 4c9e056 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new setting to the setup screen to select the minimal word length.
Shorter words entered by the user will not be checked. The grid above the board displays a white 'x' instead of the number and the results page will not display shorter words.
Current possible values as '2+', '3+' and '4+'.