Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

released version is missing makemigrations changes #84

Closed
manelclos opened this issue Nov 12, 2015 · 6 comments
Closed

released version is missing makemigrations changes #84

manelclos opened this issue Nov 12, 2015 · 6 comments

Comments

@manelclos
Copy link
Contributor

Hi,

As my Client class inherits from Organization, the initial migration will depen on a new created migration which is not going to be available (it was just created, locally):

Migrations for 'organizations':
0002_auto_20151112_1643.py:
- Alter field created on organization
- Alter field modified on organization
- Alter field created on organizationowner
- Alter field modified on organizationowner
- Alter field created on organizationuser
- Alter field modified on organizationuser

Would you mind fixing the missing migration and releasing again? this is critical for making it work correctly. Thanks!

@avelis
Copy link
Contributor

avelis commented Nov 17, 2015

It looks like commit SHA 150299f contains the migration file in question. An upgrade of django-extensions for testing created the resulting file. It is most likely what any developer also using django-extensions with this project is experiencing.

At this point we would only need a new release encompassing this change. Or if you are in a hurry you could install a version from 150299f or later.

@manelclos
Copy link
Contributor Author

Hi Avelis, a new release would be great! Thanks!

@bennylope
Copy link
Owner

I can try pulling that commit out into the master branch, but unfortunately that's on the dev branch which is much farther ahead and not ready for release.

@avelis
Copy link
Contributor

avelis commented Dec 2, 2015

@bennylope hmm I understand now the branch issue. I didn't make the connection at first...

@bennylope
Copy link
Owner

Going to close this as the issue should be wrapped into #87

bennylope added a commit that referenced this issue Jan 6, 2016
There's no magic to protect against the installed field class from being
used in the migration when what we want is a configurable field, loading
the configured class at migration time. This fixes two issues by
ensuring the migration uses the class specified by the end user.

May result in a ghost migration for existing users of the dev version.

Refs gh-84
Closes gh-87
@bennylope
Copy link
Owner

The fix deployed in 4efb7fc is going to result in what was considered a "ghost" migration under South.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants