Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Interfaces generation #71

Merged
merged 12 commits into from
Aug 13, 2019
Merged

feat: Interfaces generation #71

merged 12 commits into from
Aug 13, 2019

Conversation

ffflorian
Copy link
Member

@ffflorian ffflorian commented Aug 8, 2019 •
edited

Examples:

Screenshot

Screenshot

This closes #58.

@ffflorian ffflorian mentioned this pull request Aug 8, 2019
Closed
bennycode
bennycode approved these changes Aug 12, 2019
View reviewed changes
Copy link
Member

@bennycode bennycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and it works fine. Optionals in definitions are also treated properly. Well done! 👍

@bennycode
Copy link
Member

@ffflorian I added fixtures for an initial test.

@ffflorian
Copy link
Member Author

Perfect, thanks!

@ffflorian ffflorian merged commit 59e5649 into master Aug 13, 2019
@ffflorian ffflorian deleted the feat/interfaces branch August 13, 2019 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bennycode bennycode bennycode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extract types
2 participants
@ffflorian @bennycode