Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional <apollo-query> and <apollo-mutation> elements #11

Closed
bennypowers opened this issue Jul 24, 2018 · 6 comments
Closed

Add optional <apollo-query> and <apollo-mutation> elements #11

bennypowers opened this issue Jul 24, 2018 · 6 comments

Comments

@bennypowers
Copy link
Member

I'm thinking we can distribute optional elements/apollo-query.js and elements/apollo-mutation.js that would basically follow the pattern set out in the README
@LasaleFamine @FluorescentHallucinogen What do you think about that? I think we can start experimenting with the design for <apollo-mutation> set out in #2 (comment) and see where it takes us.

@LasaleFamine
Copy link
Contributor

Although I won't like to use custom elements for my queries I think this could be useful for some.
I'm not sure, but how will these elements share the apollo-client? I'll should pass it down?

@bennypowers
Copy link
Member Author

bennypowers commented Jul 24, 2018 via email

@FluorescentHallucinogen
Copy link
Contributor

I'm interested in <apollo-query>, <apollo-mutation> and <apollo-subscription> custom elements.

They will help users migrate from polymer-apollo-client.

@FluorescentHallucinogen
Copy link
Contributor

Just found that on https://webcomponents.org/element/lit-apollo page ApolloMutation is listed in the "Elements" section, but ApolloQuery is not, ApolloQuery is listed in the "Classes" section, but ApolloMutation is not:

webcomponents.org

It looks strange, because I haven't found customElements.define('apollo-mutation', ApolloMutation); anywhere in the code. It was in the previous versions (https://github.com/bennypowers/lit-apollo/blob/v0.6.4/apollo-mutation.js#L186), but now it's removed.

ApolloQuery is actually a class (https://github.com/bennypowers/lit-apollo/blob/master/apollo-query.js#L64).

@bennypowers How is that even possible? 🤔

@bennypowers
Copy link
Member Author

Probably some mismatched JSDoc comments

@bennypowers bennypowers mentioned this issue Nov 29, 2018
@bennypowers
Copy link
Member Author

Closed by d056b63

If problem persists after next release, feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants