Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge daily and delivery files into a single CSV file #62

Closed
BennyThadikaran opened this issue Oct 30, 2023 · 0 comments
Closed

Merge daily and delivery files into a single CSV file #62

BennyThadikaran opened this issue Oct 30, 2023 · 0 comments
Assignees
@BennyThadikaran
Labels
enhancement New feature or request

Comments

@BennyThadikaran
Copy link
Owner

User @ramkdlr raised a suggestion to merge the OHLCV and delivery files into a single file.

See discussion here

The new columns will be like
Open, High, Low, Close, Volume, TOTAL_TRADES, QTY_PER_TRADE, DLV_QTY

Changes will be reflected in plot.py and dget.py (No changes in their interface)
@BennyThadikaran BennyThadikaran self-assigned this Oct 30, 2023
@BennyThadikaran BennyThadikaran added the enhancement New feature or request label Oct 30, 2023
BennyThadikaran added a commit that referenced this issue Nov 3, 2023
@BennyThadikaran
- Fix: replace 'TOTTRDVAL' with 'TOTTRDQTY'. Resolves issue #62
d22e1ba
BennyThadikaran added a commit that referenced this issue Nov 3, 2023
@BennyThadikaran
- Resolved issue #62
d853ffd 
- Merged OHLC and delivery files.
- added modications to code
- Updated submodule eod2_data
@BennyThadikaran BennyThadikaran mentioned this issue Nov 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BennyThadikaran BennyThadikaran

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BennyThadikaran