Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility from django1.5 to django1.11 with python 2.7 and 3.x #140

Merged
merged 5 commits into from Sep 14, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 10 additions & 5 deletions .travis.yml
@@ -1,23 +1,28 @@
language: python
python:
- "3.5"
env:
- TOXENV=py27-django15
- TOXENV=py27-django16
- TOXENV=py27-django17
- TOXENV=py27-django18
- TOXENV=py27-django19
- TOXENV=py33-django15
- TOXENV=py33-django16
- TOXENV=py33-django17
- TOXENV=py27-django110
- TOXENV=py27-django111
- TOXENV=py34-django15
- TOXENV=py34-django16
- TOXENV=py34-django17
- TOXENV=py34-django18
- TOXENV=py34-django19
- TOXENV=py34-django110
- TOXENV=py34-django111
- TOXENV=py35-django18
- TOXENV=py35-django19
- TOXENV=py34-django110
- TOXENV=py34-django111
- TOXENV=flake8
- TOXENV=sphinx
- TOXENV=readme
# - TOXENV=sphinx
# - TOXENV=readme
install:
script:
- make test
9 changes: 6 additions & 3 deletions demo/demoproject/apache/urls.py
@@ -1,13 +1,16 @@
"""URL mapping."""
from django.conf.urls import patterns, url
from django.conf.urls import url

from demoproject.apache import views
from demoproject.urlpatterns import patterns


urlpatterns = patterns(
'demoproject.apache.views',
url(r'^optimized-by-middleware/$',
'optimized_by_middleware',
views.optimized_by_middleware,
name='optimized_by_middleware'),
url(r'^optimized-by-decorator/$',
'optimized_by_decorator',
views.optimized_by_decorator,
name='optimized_by_decorator'),
)
4 changes: 2 additions & 2 deletions demo/demoproject/http/urls.py
@@ -1,7 +1,7 @@
from django.conf.urls import patterns, url
from django.conf.urls import url

from demoproject.http import views

from demoproject.urlpatterns import patterns

urlpatterns = patterns(
'',
Expand Down
9 changes: 6 additions & 3 deletions demo/demoproject/lighttpd/urls.py
@@ -1,13 +1,16 @@
"""URL mapping."""
from django.conf.urls import patterns, url
from django.conf.urls import url

from demoproject.lighttpd import views
from demoproject.urlpatterns import patterns


urlpatterns = patterns(
'demoproject.lighttpd.views',
url(r'^optimized-by-middleware/$',
'optimized_by_middleware',
views.optimized_by_middleware,
name='optimized_by_middleware'),
url(r'^optimized-by-decorator/$',
'optimized_by_decorator',
views.optimized_by_decorator,
name='optimized_by_decorator'),
)
10 changes: 7 additions & 3 deletions demo/demoproject/nginx/urls.py
@@ -1,13 +1,17 @@
"""URL mapping."""
from django.conf.urls import patterns, url

from django.conf.urls import url

from demoproject.nginx import views
from demoproject.urlpatterns import patterns


urlpatterns = patterns(
'demoproject.nginx.views',
url(r'^optimized-by-middleware/$',
'optimized_by_middleware',
views.optimized_by_middleware,
name='optimized_by_middleware'),
url(r'^optimized-by-decorator/$',
'optimized_by_decorator',
views.optimized_by_decorator,
name='optimized_by_decorator'),
)
4 changes: 2 additions & 2 deletions demo/demoproject/object/urls.py
@@ -1,7 +1,7 @@
from django.conf.urls import patterns, url
from django.conf.urls import url

from demoproject.object import views

from demoproject.urlpatterns import patterns

urlpatterns = patterns(
'',
Expand Down
4 changes: 2 additions & 2 deletions demo/demoproject/path/urls.py
@@ -1,7 +1,7 @@
from django.conf.urls import patterns, url
from django.conf.urls import url

from demoproject.path import views

from demoproject.urlpatterns import patterns

urlpatterns = patterns(
'',
Expand Down
34 changes: 33 additions & 1 deletion demo/demoproject/settings.py
@@ -1,7 +1,11 @@
# -*- coding: utf-8 -*-
"""Django settings for django-downloadview demo project."""

from distutils.version import StrictVersion
import os

from django.utils.version import get_version


# Configure some relative directories.
demoproject_dir = os.path.dirname(os.path.abspath(__file__))
Expand Down Expand Up @@ -112,7 +116,6 @@

# Test/development settings.
DEBUG = True
TEMPLATE_DEBUG = DEBUG
TEST_RUNNER = 'django_nose.NoseTestSuiteRunner'
NOSE_ARGS = [
'--verbosity=2',
Expand All @@ -122,3 +125,32 @@
'--with-coverage',
'--with-doctest',
]

if StrictVersion(get_version()) >= StrictVersion('1.8'):
TEMPLATES = [
{
'BACKEND': 'django.template.backends.django.DjangoTemplates',
'DIRS': [
os.path.join(os.path.dirname(__file__), "templates"),
],
'OPTIONS': {
'debug': DEBUG,
'context_processors': [
# Insert your TEMPLATE_CONTEXT_PROCESSORS here or use this
# list if you haven't customized them:
'django.contrib.auth.context_processors.auth',
'django.template.context_processors.debug',
'django.template.context_processors.i18n',
'django.template.context_processors.media',
'django.template.context_processors.static',
'django.template.context_processors.tz',
'django.contrib.messages.context_processors.messages',
],
},
},
]
else:
TEMPLATE_DEBUG = DEBUG
TEMPLATE_DIRS = (
os.path.join(os.path.dirname(__file__), "templates"),
)
3 changes: 2 additions & 1 deletion demo/demoproject/storage/urls.py
@@ -1,6 +1,7 @@
from django.conf.urls import patterns, url
from django.conf.urls import url

from demoproject.storage import views
from demoproject.urlpatterns import patterns


urlpatterns = patterns(
Expand Down
5 changes: 5 additions & 0 deletions demo/demoproject/urlpatterns.py
@@ -0,0 +1,5 @@
try:
from django.conf.urls import patterns
except:
def patterns(prefix, *args):
return list(args)
4 changes: 3 additions & 1 deletion demo/demoproject/urls.py
@@ -1,6 +1,8 @@
from django.conf.urls import patterns, include, url
from django.conf.urls import include, url
from django.views.generic import TemplateView

from demoproject.urlpatterns import patterns


home = TemplateView.as_view(template_name='home.html')

Expand Down
3 changes: 2 additions & 1 deletion demo/demoproject/virtual/urls.py
@@ -1,6 +1,7 @@
from django.conf.urls import patterns, url
from django.conf.urls import url

from demoproject.virtual import views
from demoproject.urlpatterns import patterns


urlpatterns = patterns(
Expand Down
11 changes: 10 additions & 1 deletion tox.ini
@@ -1,5 +1,5 @@
[tox]
envlist = py{27}-django{15,16,17,18,19}, py{33,34}-django{15,16,17}, py{34,35}-django{18,19}, flake8, sphinx, readme
envlist = py{27}-django{15,16,17,18,19,110,111}, py{33,34}-django{15,16,17}, py{34,35}-django{18,19,110,111}, flake8, sphinx, readme

[testenv]
basepython =
Expand All @@ -10,10 +10,19 @@ basepython =
deps =
coverage
django15: Django>=1.5,<1.6
django15: django-nose<1.4.3
django16: Django>=1.6,<1.7
django16: django-nose<1.4.3
django17: Django>=1.7,<1.8
django17: django-nose<1.4.3
django18: Django>=1.8,<1.9
django18: django-nose>=1.4.2
django19: Django>=1.9,<1.10
django19: django-nose>=1.4.3
django110: Django>=1.10,<1.11
django110: django-nose>=1.4.4
django111: Django>=1.11,<2.0
django111: django-nose>=1.4.5
nose
py27: mock
commands =
Expand Down