Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

Test/loading #2

Closed
NeoDigi opened this issue Jul 24, 2018 · 1 comment
Closed

Test/loading #2

NeoDigi opened this issue Jul 24, 2018 · 1 comment

Comments

@NeoDigi
Copy link

NeoDigi commented Jul 24, 2018

Hey thank you for this app, this is awesome, I'm using it as kind of a template for an app of my own.

I was wondering if you intended to make some test for it?

Also I realized something is that firebase is supposed to work offline too but in your current implementation it doesn't, and for the user experience it'd be awesome to have that.
I don't know if it's currently possible with the current state of flutter but for example your loading all data in the loading state Everytime and I think that the data already on the device should be already displayed even during the loading state.
To be honest I did try to do just that but couldn't make it work so I was wondering if you had any idea or if you also intended to implement it latter?

Ok really nice work so far

@benoitletondor
Copy link
Owner

Hi @NeoDigi !

About tests:

  • The MVI architecture extract the logic into models which are highly testable since they are pure dart without any Flutter related stuff, and you can easily mock services to test behaviour
  • I didn't try to write any UI test so I can't help you with that

About offline firestore: Yes offline doesn't seem to work right now, maybe an issue with firestore client? To be honest it wasn't really important for my app as it would still depend on network for beer list fetch so I didn't try very hard. Let me know if you make some progress on that point.

Thank you again for your nice words, appreciate it :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants