Sync system logos with es-theme-artbook-next #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-theme-art-book-next There is a small conversion process needed that can be automated using inkscape on linux to: `for img in $(ls *.svg) ; do inkscape --verb=FitCanvasToDrawing --verb=FileSave --verb=FileQuit $img ; done` Also - after converting you can use the available systems in es_systems to copy just the needed .svg files like this: `cat /storage/.emulationstation/es_systems.cfg | grep -i "<name>" | sed "s/<name>//g" | sed "s|</name>|.svg|g" | awk '{$1=$1};1' | xargs -I '{}' mv '{}' ./all/`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
System logos were pulled in ad hoc during development of the Web UI. Soon - we will be switching to the es-theme-art-boot-next theme (https://github.com/anthonycaccese/es-theme-art-book-next) across all 351ELEC devices. Ideally (at least default) ES system logos should be synced up with the web UI.
This PR adds all system logos from artbook-next. It uses a small conversion process due to some issues described below in loading directly from the artbook next installation within 351ELEC.
Issue Using Artbook SVG logos directly
Ideally, the web UI could actually load the logos directly from the artbook installation within 351ELEC and not duplicate svgs, however, there appears to be an issue. For some reason (I don't claim to be an svg expert), many of the existing artbook logos don't work properly when using in the browser with the web ui. Ex:
This is what it should look like:
Conversion Process
Manual Fix In inkscape - you can manually fix by:
File->Document Properties->Resize Page To Content-> pressResize Page to drawing or selectionand then save the svg file.Automated Fix - Instead of trying to convert one by one, I came up with a very rough automated conversion process to bulk convert from artbook next using inkscape on linux. This is mostly for my reference or if anyone else wants to bulk fix these images for webui consumption.
Tell inkspace to
FitCanvasToDrawingfor all images (https://github.com/anthonycaccese/es-theme-art-book-next/tree/main/_inc/images/systems/logos) you wish to convert.for img in $(ls *.svg) ; do inkscape --verb=FitCanvasToDrawing --verb=FileSave --verb=FileQuit $img ; doneUse availble systems in es_systems to copy just the needed .svg files:
cat /storage/.emulationstation/es_systems.cfg | grep -i "<name>" | sed "s/<name>//g" | sed "s|</name>|.svg|g" | awk '{$1=$1};1' | xargs -I '{}' mv '{}' ./all/