Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add category icons #301

Merged
merged 15 commits into from Nov 4, 2022
Merged

Feature: add category icons #301

merged 15 commits into from Nov 4, 2022

Conversation

maharsh9100
Copy link
Contributor

Changes in this PR are as follows:

  • Add custom icons to the title/category header#215
  • Updates the services.yaml file
  • Export the resolveIcon function into Utils for reusability

Note: One of the commit message is "Update setting.yaml mapping" which is incorrect while the commit on is fine.

@maharsh9100
Copy link
Contributor Author

I'll work on resolving the conflicts.

@maharsh9100 maharsh9100 reopened this Sep 28, 2022
@maharsh9100
Copy link
Contributor Author

I have resolved all the merge conflicts. Really great project!!! 😃

@shamoon
Copy link
Collaborator

shamoon commented Oct 21, 2022

Thank you for the PR. I think some people may want this but this PR is a bit problematic imho as it alters the config schema i.e. it completely breaks an existing install's services...

At the very least it would need some kind of migration (not a good idea I think), otherwise I would consider a different way to do this, for example putting it in the layout map of the settings yaml or something like that. Even though the current way is 'cleaner', a complete breaking change just for this seems incongruous.

Also, code needs cleanup but I will hold off on that for now as the above is a 'show-stopper', again just IMHO.

@shamoon shamoon marked this pull request as draft October 21, 2022 05:58
@shamoon
Copy link
Collaborator

shamoon commented Oct 22, 2022

Have a look, I think its much simpler now to achieve this =)

settings.yaml:

layout:
  Home Management:
    icon: https://cdn-icons-png.flaticon.com/512/25/25694.png

Of course please let me know if you disagree

@shamoon shamoon changed the title Feature/add custom category icons[Issue #215] Feature: add category icons Oct 22, 2022
@shamoon shamoon marked this pull request as ready for review October 22, 2022 14:55
@shamoon
Copy link
Collaborator

shamoon commented Nov 4, 2022

Needs a squash, if merged.

@shamoon shamoon merged commit 71faaa5 into gethomepage:main Nov 4, 2022
Copy link
Contributor

github-actions bot commented Feb 6, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants