Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add homebridge widget #442

Merged
merged 8 commits into from Oct 25, 2022
Merged

Conversation

fneiraj
Copy link
Contributor

@fneiraj fneiraj commented Oct 24, 2022

Simple homebridge widget,

How to use:

    - Homebridge:
        icon: homebridge.png
        container: homebridge
        service: homebridge
        href: http://your-ip-address:8581
        description:
        widget:
            type: homebridge
            url: http://your-ip-address:8581
            username: your-username
            password: your-password

Preview:

image

If you dont have child bridges:

image

@shamoon
Copy link
Collaborator

shamoon commented Oct 24, 2022

Nice, it works! =)

Couple thoughts:

  1. The API (swagger) allows for basic auth, so you dont actually need the whole proxy here... Edit: think not
  2. It could be more useful than the current items to show things like # of child bridges which many use (myself included). We could make it only show if n > 0? Only problem is its another API call. /api/status/homebridge/child-bridges. I'll have a think
  3. Technically, this requires Config UI X (thats where the API comes from). Most people, especially at this point, have this, but its not actually required. We can note this in the docs.

Let me know your thoughts on # 2, I can help out with # 1 if you'd like

@shamoon
Copy link
Collaborator

shamoon commented Oct 24, 2022

Edit: think Im wrong about that basic auth =) I'll look at it more later!

@shamoon shamoon linked an issue Oct 24, 2022 that may be closed by this pull request
@fneiraj
Copy link
Contributor Author

fneiraj commented Oct 24, 2022

@shamoon update the preview image, and add child_bridges api support :)

@shamoon
Copy link
Collaborator

shamoon commented Oct 24, 2022

Love it! I'll take a look later when I have some real time, thanks for the pr!

@shamoon shamoon self-assigned this Oct 24, 2022
@shamoon
Copy link
Collaborator

shamoon commented Oct 24, 2022

Just some minor stuff, works great though =)

I will take a final look at it tonight, thanks again

@shamoon shamoon merged commit 68631a6 into gethomepage:main Oct 25, 2022
@shamoon
Copy link
Collaborator

shamoon commented Oct 25, 2022

Nice work!

@fneiraj fneiraj deleted the widget/homebridge branch October 25, 2022 12:43
Copy link
Contributor

github-actions bot commented Feb 6, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Homebridge Widget
2 participants