Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Searchbar & Nginx Proxy Manager #45

Merged
merged 10 commits into from Sep 2, 2022
Merged

Conversation

aidenpwnz
Copy link
Contributor

Searchbar for google, bing, duckduckgo and custom search providers.

Includes fixes to responsiveness and overflows for mobile.

desktop

mobile

@benphelps
Copy link
Member

This is wonderful, thank you! Would you be opposed to some CSS tweaks to bring it more inline with the rest of the design pattern? I'll be more than happy to make the changes myself after a merge.

@aidenpwnz
Copy link
Contributor Author

This is wonderful, thank you! Would you be opposed to some CSS tweaks to bring it more inline with the rest of the design pattern? I'll be more than happy to make the changes myself after a merge.

Sure have at it! This feature definitely needs more polishing.
If you need any help let me know.

@aidenpwnz
Copy link
Contributor Author

I think I messed up a bit the pr... Well I just added NGINX Proxy Manager service widget, shouldn't create too much trouble. Let me know if I should fix!

@benphelps
Copy link
Member

Both parts look good, I'll pull them in and do a little cleanup tomorrow morning. Thank you again :)

@benphelps benphelps merged commit 229c5da into gethomepage:main Sep 2, 2022
@benphelps
Copy link
Member

@aidenpwnz Just wanted to give an update. I've tweaked the mobile layout a bit more and pulled the styles from panels below up for the search bar. Along with some simplification of the code.

Screenshot 2022-09-03 at 12 56 10 PM

Screenshot 2022-09-03 at 12 56 17 PM

The border radius of the inside button being ever so slightly bigger on the corners is driving me nuts but I'll leave that for another day.

@benphelps benphelps changed the title Feature/Searchbar Feature/Searchbar & Nginx Proxy Manager Sep 3, 2022
Copy link
Contributor

github-actions bot commented Feb 6, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants