New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Added support to watchtower statistics #455
Conversation
Thanks for the PR, please revert changes to the language files other then en, the others are updated through the weblate platform. Myself (or someone else) will review this asap |
Oh, I didn't know it, thanks. |
Is there a way to make the labels clearer? I recognize that naming things is hard, and it might not be possible to make clearer, however without clearer labels, translators will have a harder time coming up with good translations. |
The first statistic indicates the number of times a scan is performed by the service, while the other ones refer to the number of containers scanned, updated and failed in the last scan. I wanted to add both types of statistics, but I recognize that this can create confusion and not clear labels. Removing the first statistic and using |
Yea that makes sense to me. Curious, what do you link to with a watchtower widget, anything? |
Sorry, English is not my primary language. What do you mean by your question? Which watchtower's API do I use to get the values? |
It’s not so important, just curious whether you would use this without an |
Oh, well I added also watchtower to homepage because it is easier and more immediate to check the container's statistics with it respect to portainer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you have a chance, please address the comments above, removing all common.json changes except for en and reworking the field names, etc. Thanks!
I did the changes, but before to commit I wanted to test everything inside a container. Unfortunately, I have some troubles with docker buildx build.
Docker version: 20.10.18 |
Yes, the build isnt working right now unfortunately, unclear issues with the arm builds. No ETA yet, but thanks for your patience. Its still easy enough to test locally but up to you |
c80d2a2
to
45e7226
Compare
Great, thanks for the PR |
Thanks to you for your help! |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. |
Added widget support for watchtower statistics.
How to use:
--http-api-metrics
--http-api-token
and bind port8080
as described here.services.yml
file, as shown below:Preview: