Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the option for a bookmark icon #487

Merged
merged 1 commit into from Nov 4, 2022

Conversation

donslice
Copy link

@donslice donslice commented Nov 4, 2022

#291

Same functionality as service icons. Falls back to abbreviation.

firefox_x414AUoKJk

…ons). Falls back to abbreviation.

Revert "Adds the option for a bookmark icon (same functionality as service icons). Falls back to abbreviation."

This reverts commit d713158.

Add icons to bookmarks
@shamoon
Copy link
Collaborator

shamoon commented Nov 4, 2022

Thanks for the PR, I updated this to use the shared functionality for ResolvedIcon, and rebased. Its a very straightforward PR now =)

Screen Shot 2022-11-04 at 2 52 48 PM

@shamoon shamoon merged commit b438cc2 into gethomepage:main Nov 4, 2022
Copy link
Contributor

github-actions bot commented Feb 6, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants