Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Deluge widget #551

Merged
merged 6 commits into from Nov 26, 2022
Merged

Add Deluge widget #551

merged 6 commits into from Nov 26, 2022

Conversation

JazzFisch
Copy link
Collaborator

  • Create semi-generic jsonrpc proxy handler
  • Refactor NZBGet to use jsonrpc proxy handler

closes #190

- Create semi-generic jsonrpc proxy handler
- Refactor NZBGet to use jsonrpc proxy handler

closes gethomepage#190
@JazzFisch
Copy link
Collaborator Author

I'm not enthused by the number of JSON.stringify calls I have in here, but because of the way that the RPC client likes to automagically extract JSON in some places and not others (especially around error sites) I couldn't think of a cleaner way.

@JazzFisch
Copy link
Collaborator Author

Also, NZBGet needs to be tested with this change and I don't have an instance running locally.

@shamoon
Copy link
Collaborator

shamoon commented Nov 23, 2022

Nice! I should be able to check it out at some point soon too

@shamoon shamoon force-pushed the add-deluge branch 3 times, most recently from c2af1fb to cc02fa9 Compare November 24, 2022 06:16
Copy link
Collaborator

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bravo

Screen Shot 2022-11-23 at 3 07 42 PM

Screen Shot 2022-11-23 at 10 25 55 PM

@shamoon shamoon merged commit ff27d90 into gethomepage:main Nov 26, 2022
@JazzFisch JazzFisch deleted the add-deluge branch November 27, 2022 23:24
Copy link
Contributor

github-actions bot commented Feb 6, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Deluge widget
2 participants