Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed number formatting in widgets: radarr, sonarr, overseerr #721

Merged
merged 1 commit into from
Dec 23, 2022

Conversation

kimpenhaus
Copy link
Contributor

@kimpenhaus kimpenhaus commented Dec 23, 2022

I've fixed some of the widgets to give them some proper number formatting while using the i18n-translator

widgets:

  • sonarr
  • radarr
  • overseerr

sample when having culture information setup to: de-DE

before:
image

after:
image

@Nonoss117
Copy link
Contributor

Good idea, I agree with you, numbers formatting for radarr, sonarr, overseerr widgets can be improved.
But I think number formatting is different depending on the country.
In France we use space for this formatting.

This is an example of TubeArchivist widget and its fine for me.
image

@kimpenhaus
Copy link
Contributor Author

kimpenhaus commented Dec 23, 2022

It uses the provided i18n translator - so I think it should respect the given culture information. I have update some description text of the PR

@shamoon
Copy link
Collaborator

shamoon commented Dec 23, 2022

Nice thanks. Yes as this uses the translation function (like in other widgets) it will respect localization

@shamoon shamoon merged commit ca2f0ab into gethomepage:main Dec 23, 2022
@Nonoss117
Copy link
Contributor

Nonoss117 commented Dec 23, 2022

Arrr too late, I wanted to ask the same for prowlarr widget :
image

shamoon added a commit that referenced this pull request Dec 23, 2022
@shamoon
Copy link
Collaborator

shamoon commented Dec 23, 2022

Arrr too late, I wanted to ask the same for prowlarr widget :

No worries, added in 1cac02f

@kimpenhaus kimpenhaus deleted the bugfix/widget-number-format branch December 23, 2022 16:32
Copy link
Contributor

github-actions bot commented Feb 6, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants