-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pictures cannot display in windows file browser. #83
Comments
Hmmm... I played around with it for a bit this evening and so far haven't been able to directly reproduce your issue. I do however notice neither windows nor Foobar2000 seem to recognize ID3v2 tags placed at the end of the file with
const file = taglib.File.createFromPath("pathtofile");
const cover = taglib.Picture.fromPath("pathtopicture");
const oldId3v2 = file.getTag(taglib.TagTypes.Id3v2, false);
file.removeTags(0xFFFFFFFF);
const newId3v2 = file.getTag(taglib.TagTypes.Id3v2, true);
oldId3v2.copyTo(newId3v2, true);
// make changes via file.tag
file.save();
file.dispose(); Inspecting the file I tested with, I see the image is being added to the tag and |
Hi @RogerChen2005 yes, ID3v2.4 still isn't supported in nearly as many places as ID3v2.3 is. Glad you found a workaround. The investigation for your issue also uncovered a related issue with ID3v2 tags at the end of a file. I'll track that in a separate issue, but thanks for helping bring it to my attention. |
When attaching pictures to .mp3 files, the cover cannot display in windows file browser.
The result I get:
![{7E01F5C4-7825-4e3a-BBAC-44DC493A78BE}](https://private-user-images.githubusercontent.com/52621823/258789664-de222901-729e-4a3d-97d0-1c49c8e7ef06.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk2MjQxNDMsIm5iZiI6MTcxOTYyMzg0MywicGF0aCI6Ii81MjYyMTgyMy8yNTg3ODk2NjQtZGUyMjI5MDEtNzI5ZS00YTNkLTk3ZDAtMWM0OWM4ZTdlZjA2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI5VDAxMTcyM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWY1OTk4NTJjZjFiYTcyOGMyODZjOTgxYTE5YmJkYTI4NzhkOWI0OTc1NTNhNjZmN2NiM2IwOTFhMzI2MjJiOGQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.ZVfFNLG_ZWPP0jYSRQj0Dpki-rS5CyqTibzi_OmCGPE)
![{49347EBB-C0A0-43ae-85B3-6D7940FF73D8}](https://private-user-images.githubusercontent.com/52621823/258789886-2e87e491-8ab1-4e70-a21a-d858fdb6a93f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk2MjQxNDMsIm5iZiI6MTcxOTYyMzg0MywicGF0aCI6Ii81MjYyMTgyMy8yNTg3ODk4ODYtMmU4N2U0OTEtOGFiMS00ZTcwLWEyMWEtZDg1OGZkYjZhOTNmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI5VDAxMTcyM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTY1OGY5MGFiMGM0YmU5NWFlMDBkNmI3MjUyZjg1MzdiOWUxNGY5N2I2ODg1MWMxMjFmMDFhYTI5YWFhODNhZjcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.7LOSWlyLV-Bub9Lq1D6X0FHInStQr8nQK8Ld4UQWSRw)
However, Foobar2000 can read the picture:
The text was updated successfully, but these errors were encountered: