You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@bensampaio
The SvgDocument.js method does not add the fill attribute, Expect to add it in versions 6.0 and 7.0.
// Create the symbol attributes
['class', 'preserveAspectRatio', 'viewBox'].forEach((name) => {
const value = this.getAttribute(name);
if (value) {
attrs.push(`${name}="${value}"`);
}
});
A bugreport here:
https://github.com/karify/external-svg-sprite-loader/blob/842c04a092665b724a25c9c4ff36b974808a0821/lib/SvgDocument.js#L170
Due to this explicit whitelist of attributes,
becomes
I.e. fill="none" is removed and thus the image changes.
Maybe we can just copy all attributes (or blacklist some) instead of whitelisting? Because
fill
may not be the only one attribute...The text was updated successfully, but these errors were encountered: