Skip to content
This repository has been archived by the owner on Jan 2, 2024. It is now read-only.

2nd, 3rd, 4th images are dropped down about 20 px #11

Closed
digibrink opened this issue Mar 25, 2014 · 10 comments
Closed

2nd, 3rd, 4th images are dropped down about 20 px #11

digibrink opened this issue Mar 25, 2014 · 10 comments

Comments

@digibrink
Copy link

Hi,

This is great but I am having a few issues. All secondary images in the slideshow (1 is good, 2-5 are off) are dropped down and I can't get them positioned correctly. See screenshots. Any help would be greatly appreciated. Thanks!!

Justin

screen shot 2014-03-25 at 6 50 47 pm
screen shot 2014-03-25 at 6 51 24 pm
screen shot 2014-03-25 at 6 51 37 pm
screen shot 2014-03-25 at 6 51 55 pm

@digibrink
Copy link
Author

Note all images are the same size, 960 x 540px. Attached is the CSS. I didn't modify the rest of the code aside from changing the color of the control dots.

screen shot 2014-03-25 at 6 53 13 pm

@benschwarz
Copy link
Owner

Interesting — do you have the site on a staging somewhere where I can inspect it?

@digibrink
Copy link
Author

Wow Ben your response time is great. I got frustrated and left work.

I'll put it online and send you the link tomorrow. Thanks again!!

@benschwarz
Copy link
Owner

No problem. I think its more a case of getting me right at the perfect time to respond :-)

@digibrink
Copy link
Author

Here's the live version:

http://www.beautyisdesigned.com/portfolio/index.html

I added the BG color back in to emphasize the positioning issue.

Thanks for the help!!

@benschwarz
Copy link
Owner

@digibrink You'll need to add margin: 0; to the figure elements.

figure { margin: 0; }

Looks like they're not covered by your CSS reset.

@digibrink
Copy link
Author

You are amazing!!! Thank you so much!

@digibrink
Copy link
Author

Ok. I feel dumb, but let's face it -- I am awful at code. Everything is working great, except I can't duplicate the functionality of the code for the next item down the page (the next div). It just loads the images into the first div (for ex. the 2nd button in either project loads project A's 2nd image [#item-2] into the first div).

I assume it has to do with naming convention -- do I need a full css script per project? That seems like overkill but every time I try to fix it I break the whole page.

http://www.beautyisdesigned.com/portfolio/index.html

Any help would be greatly appreciated.

Thanks!
Justin

@digibrink
Copy link
Author

Derp. Nevermind I think I figured it out. It was a naming issue, I was just renaming the wrong things. Online site updated.

@dharapvj
Copy link

dharapvj commented Sep 4, 2015

Exactly my issue too!

My reset was incorrect! saved my day..

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants