Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config.good_job.preserve_job_records = false not working with CRON #927

Closed
ollym opened this issue Apr 12, 2023 · 1 comment
Closed

config.good_job.preserve_job_records = false not working with CRON #927

ollym opened this issue Apr 12, 2023 · 1 comment

Comments

@ollym
Copy link

ollym commented Apr 12, 2023

When good_job runs a cron job its preserved in state finished even though we have preserve_job_records = false

@bensheldon
Copy link
Owner

This is intentional. Cron uses a unique index on (cron_key, cron_at) columns. That requires keeping the record around, otherwise it's possible that multiple jobs could be enqueued if the record is immediately deleted after running.

It's not ideal, but necessary for how cron currently works.

There's more detail in #767 / #731

@bensheldon bensheldon closed this as not planned Won't fix, can't repro, duplicate, stale Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants