Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teleporting between worlds gives an error #12

Closed
TheBentoBox opened this issue Mar 14, 2016 · 4 comments
Closed

Teleporting between worlds gives an error #12

TheBentoBox opened this issue Mar 14, 2016 · 4 comments
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.

Comments

@TheBentoBox
Copy link
Member

When teleporting between two separate worlds, a stack trace appears in console saying "cannot measure distance between worlds". I think it's because of the changes in this commit. Particularly this line:

if (to.equals(from) || to.distanceSquared(from) < 2)

I don't write plugins, but looking at the Bukkit API, it looks like you'd want to change that whole section to:

if (to.equals(from))  
    return;
else if (to.getWorld() == from.getWorld())
    if (to.distanceSquared(from) < 2)
        return;

Stacktrace.

@bensku
Copy link
Member

bensku commented Mar 14, 2016

Uh... Didn't consider that, but you're right. Sadly I found this issue just after stopping coding for today; fix will come tomorrow.

I'm literally drowning in bugs; got some nasty ones fixed in last release, reported by Pilvinen internally in our server's forums :)

@bensku bensku added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Mar 14, 2016
@TheBentoBox
Copy link
Member Author

Nice, sounds ok. Just to let you know, it turns out this bug does have a side effect - it breaks portals, people can't get to the Nether at all. I assume the End portals won't work as well, but I'll check and report back here.

@TheBentoBox
Copy link
Member Author

Turns out end portals still work, it's just Nether portals that don't. Both send an error to console of course (as any teleport or teleport attempt does), but it's just Nether portals that break entirely.

@bensku
Copy link
Member

bensku commented Mar 15, 2016

Should be fixed in next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.
Projects
None yet
Development

No branches or pull requests

2 participants