Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile-time stdout corrupts JS output #109

Open
moea opened this issue Jun 27, 2016 · 3 comments
Open

Compile-time stdout corrupts JS output #109

moea opened this issue Jun 27, 2016 · 3 comments

Comments

@moea
Copy link
Contributor

moea commented Jun 27, 2016

More of a question than an issue, because I can't see where this happening after cursory inspection. I've got a dependency (Timbre) which conditionally writes to stdout at compile time. While that may not be a fantastic idea itself, when doo compiles my build the console output is redirected to the source file.

// Compiled by ClojureScript 1.8.51 {:target :nodejs}        
Compile-time (elision) Timbre level: :warn 
goog.provide('taoensso.timbre');  

The middle line being the problem. Thoughts?

Compiling via lein doo node test-none once, project file is here

@bensu
Copy link
Owner

bensu commented Jun 27, 2016

Hi @moea,

Does this happen when using cljsbuild or the compiler directly?

@moea
Copy link
Contributor Author

moea commented Jun 27, 2016

Hey! I didn't try using the compiler directly, but no, it doesn't happen with cljsbuild. w/ cljsbuild I see the compiler's console output and the print statement, which w/ doo is I guess is swallowed by whatever leiningen.core.eval is doing with subprocess output - which I can't really follow.

@bensu
Copy link
Owner

bensu commented Jun 27, 2016

Thanks for the quick reply!

This is a doo issue then. It is important to redirect the standard output of some process to get the error reporting, but the compiler should fall into that. I'll look into it and see what is the best way to solve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants