Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

symbol in project.clj causes ClassNotFoundException #133

Closed
vemv opened this issue Apr 7, 2017 · 2 comments
Closed

symbol in project.clj causes ClassNotFoundException #133

vemv opened this issue Apr 7, 2017 · 2 comments
Milestone

Comments

@vemv
Copy link

vemv commented Apr 7, 2017

Hi!

I have my cljsbuild options like this:

:compiler {:closure-defines {foo.common.env/env "dev"}}

This seems normal lein syntax. foo.common.env/env is quoted (like everything else in project.clj) and it shouldn't be evaluated as a clojure/java class.

lein repl and lein figwheel accept it. However lein doo does not - it tries to evaluate foo.common.env/env, causing a ClassNotFoundException.

I can 'solve' the issue by quoting {foo.common.env/env "dev"} with a backtick, but:

  • I shouldn't be doing that in the first place - it's normal lein syntax
  • It causes the lein figwheel validator to complain. It expects a map, not a quoted map.

Could it be the case that doo is parsing project.clj (or cljsbuild opts) in its own way?

Cheers - Victor

@metametadata
Copy link

Maybe you could use string name instead of a symbol? E.g. this define is accepted by both figwheel and doo:

:closure-defines {"app.defines.DEBUG" true}

@miikka
Copy link
Collaborator

miikka commented Mar 13, 2018

Should be fixed in [lein-doo "0.1.9"].

@miikka miikka closed this as completed Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants