Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure exit code is zero on unhandled promise rejection in node #182

Open
arichiardi opened this issue Jul 5, 2018 · 1 comment
Open

Comments

@arichiardi
Copy link
Contributor

Hello @bensu and all!

I know this is controversial and I can handle it myself in my side of the code but I was wondering whether it makes sense to adopt the following solution by default for :node targets in case of unhandled promise rejection.

https://medium.com/@dtinth/making-unhandled-promise-rejections-crash-the-node-js-process-ffc27cfcc9dd

Leaving this here for further discussion.

@Lambeaux
Copy link

Lambeaux commented Aug 30, 2021

+1, although @arichiardi I think you mean "non-zero", correct?

We got hit by this. Builds were passing in Jenkins despite the tests actually failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants