New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
platform.twitter.com #1
Comments
That's actually sort of by design - 80d32ab - having it unblocked allows Twitter's tracking. The primary aim at the time (back in 2018) was blocking the "Tweet" buttons (just as Facebook's Like button etc are blocked), but it does now appear to have the spill-over effect of breaking some tweet embeds. Obviously it'd be easier if people used screenshots instead of embedding but we can't control that. I guess, really Social Media tracker domains (like platform.twitter.com) should be split out into a separate list - much like other upstreams do. I'll have a fiddle about with it shortly |
This was the article I was using for testing I fully understand blocking tracking- just not a big fan of breaking/hiding legit content too |
Cool thanks. Yeah, I'd prefer to give a choice - I'm quite happy to have broken tweet embeds in my browser (most of the time), but I know others won't be. I think the way I'm going at this is to leave the list as is (so that behaviour doesn't change for anyone else currently using the lists), but to have new copies generate with the social media trackers absent. The code changes for that are (in theory) in place, I just need to go through the lists and identify the domains to move - there'll be some LinkedIn and Facebook in there too at the moment |
OK, there are now 3 new lists added here - https://www.bentasker.co.uk/adblock/index.html
The first two are copies of the original lists, but with the social media paths moved out. The |
Using this list - https://www.bentasker.co.uk/adblock/easylist_modified_no_sm.txt - my browser attempts to connect to platform.twitter.com when viewing your example article. Admittedly it then fails because the change hasn't made it onto the adblock list on my DNS server yet. |
Thanks! |
Possible to provide it also in Pihole compatible format? (hosts file) |
The twitter/social media domains should be excluded from the pihole file (though caches might not have expired quite yet on my CDN) I was leaning toward leaving it that way too - with ABP lists you can choose to whitelist (if you're using the list with SM included), that's harder to do with DNS lists. |
Looks like it's cleared out of the list for me
|
On second thoughts, it doesn't really make sense not to provide one, so there's now a version of the Pihole list with Social media domains here - https://www.bentasker.co.uk/adblock/blocked_domains_with_sm.txt |
Thanks! |
This domain breaks some tweets embedded in articles in Google News app on Android
The text was updated successfully, but these errors were encountered: