Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingress port mapping #25

Closed
DaniTulp opened this issue Sep 9, 2022 · 5 comments · Fixed by #68
Closed

Ingress port mapping #25

DaniTulp opened this issue Sep 9, 2022 · 5 comments · Fixed by #68
Assignees

Comments

@DaniTulp
Copy link
Contributor

DaniTulp commented Sep 9, 2022

When messing around with the ingress I think I found an issue with the way it's setup. At least it's not documented. When defining the ingress it uses the following value:

service:
   port: {number}

This doesn't seem to be in the values.yaml. I do see this service.ports field so maybe that should be used instead?

@difabion difabion self-assigned this Sep 9, 2022
@difabion
Copy link
Collaborator

difabion commented Sep 9, 2022

Admittedly, the ingress templating is not well-tested, and is mostly an artifact of the helm initialization logic for new projects. I'll get you an answer on this sometime over the weekend.

@DaniTulp
Copy link
Contributor Author

Yeah that makes sense. As the readme also states WIP + using something that's undocumented is probably not the safest thing to do ;).
Thought I'd at least mention it in case someone else hits it as well. For my use case just defining the port as shown above works perfectly fine.

@difabion
Copy link
Collaborator

Revisiting this this week, bear with me.

@DaniTulp
Copy link
Contributor Author

No worries at all, due to the needs/opinions of the organisation I work for which (imo) don't directly align with what should be provided here (some quite specific options in terms of Azure for example). I've created our own helm chart (using this as reference of course 😉) that has those opinions baked in.

@tbnguyen1407
Copy link

Hello, any progress on this issue? Currently .Values.service.port still needs to be manually added for ingress to be valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants