don't escape paths twice

redpanda-data · Apr 8, 2024 · ad20f19 · ad20f19
1 parent d5613d4
commit ad20f19
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/internal/impl/confluent/client.go b/internal/impl/confluent/client.go
@@ -169,10 +169,7 @@ func (c *schemaRegistryClient) walkReferencesTracked(ctx context.Context, seen m
 }
 
 func (c *schemaRegistryClient) doRequest(ctx context.Context, verb, reqPath string) (resCode int, resBody []byte, err error) {
-	reqURL := *c.schemaRegistryBaseURL
-	if reqURL.Path, err = url.JoinPath(reqURL.Path, reqPath); err != nil {
-		return
-	}
+	reqURL := c.schemaRegistryBaseURL.JoinPath(c.schemaRegistryBaseURL.Path, reqPath)
 
 	var req *http.Request
 	if req, err = http.NewRequestWithContext(ctx, verb, reqURL.String(), http.NoBody); err != nil {

diff --git a/internal/impl/confluent/serde_protobuf_test.go b/internal/impl/confluent/serde_protobuf_test.go
@@ -174,7 +174,7 @@ message bar {
 					},
 				},
 			}), nil
-		case "/subjects/stuffs%2Fthething.proto/versions/10", "/schemas/ids/2":
+		case "/subjects/stuffs/thething.proto/versions/10", "/schemas/ids/2":
 			return mustJBytes(t, map[string]any{
 				"id":         2,
 				"version":    10,