Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional kafka_franz input kafka consumer configuration #2573

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Additional kafka_franz input kafka consumer configuration #2573

wants to merge 7 commits into from

Commits on May 10, 2024

  1. Adds additional kafka fields to output 

    - `fetch_min_bytes`
- `fetch_max_wait_ms`
- `max_partition_fetch_bytes`
- `max_poll_records`

I've used the defaults, as what kafka defaults are

Signed-off-by: hendoxc <hagen.henderson@smartcontract.com>
    @hendoxc
    hendoxc committed May 10, 2024
    Configuration menu
    Copy the full SHA
    fbb0313 View commit details
    Browse the repository at this point in the history

  2. Changes fetch_max_wait to a Duration Field 

    matches what franz go library expects when configuring a client

Signed-off-by: hendoxc <hagen.henderson@smartcontract.com>
    @hendoxc
    hendoxc committed May 10, 2024
    Configuration menu
    Copy the full SHA
    fb27b8b View commit details
    Browse the repository at this point in the history

  3. Adds additional config fields to franzKafkaReader 

    Signed-off-by: hendoxc <hagen.henderson@smartcontract.com>
    @hendoxc
    hendoxc committed May 10, 2024
    Configuration menu
    Copy the full SHA
    4d7a170 View commit details
    Browse the repository at this point in the history

  4. Adds new fields to client instantiation 

    additionally removes `max_poll_records` as its not an available client option

Signed-off-by: hendoxc <hagen.henderson@smartcontract.com>
    @hendoxc
    hendoxc committed May 10, 2024
    Configuration menu
    Copy the full SHA
    7ee5dff View commit details
    Browse the repository at this point in the history

  5. Removes unused struct field 

    Signed-off-by: hendoxc <hagen.henderson@smartcontract.com>
    @hendoxc
    hendoxc committed May 10, 2024
    Configuration menu
    Copy the full SHA
    ad12716 View commit details
    Browse the repository at this point in the history

  6. Makes default for fetch_max_wait_duration to 5s 

    this is the franz client's default

Signed-off-by: hendoxc <hagen.henderson@smartcontract.com>
    @hendoxc
    hendoxc committed May 10, 2024
    Configuration menu
    Copy the full SHA
    0a86319 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Runs make docs

    @hendoxc
    hendoxc committed May 16, 2024
    Configuration menu
    Copy the full SHA
    77577b1 View commit details
    Browse the repository at this point in the history