Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: SSL does not work #4710

Closed
ProVega opened this issue May 6, 2024 · 2 comments
Closed

bug: SSL does not work #4710

ProVega opened this issue May 6, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@ProVega
Copy link

ProVega commented May 6, 2024

Describe the bug

Configure SSL per instructions here -
https://docs.bentoml.com/en/latest/guides/configurations.html

ssl={
"enabled": True,
"certfile": "/fullpath/file.cer",
"keyfile": "/fullpath/file.key",
"keyfile_password": "password"

Using the exact same config into Uvicorn directly, with same key and cert and password works just fine.

I don't see how to turn on additional logging, so I don't really know what the problem is.

All requests, get this warning.
2024-05-06T07:53:05-0600 [WARNING] [entry_service:bentovllm-llama3-8b-insruct-service:1] Invalid HTTP request received.
2024-05-06T07:53:05-0600 [WARNING] [entry_service:bentovllm-llama3-8b-insruct-service:1] Invalid HTTP request received.

Enabling DEBUG doesn't yield any additional info (yes I see [DEBUG] in the output for other stuff)

To reproduce

No response

Expected behavior

SSL should work

Environment

bentoml: 1.2.12
uvicorn: 0.9.0

@ProVega ProVega added the bug Something isn't working label May 6, 2024
@ProVega
Copy link
Author

ProVega commented Jun 20, 2024

Bump - Does anyone have any guidance on how to get SSL working?

@ProVega
Copy link
Author

ProVega commented Jun 20, 2024

Wow, after upgrading from 1.2.13 to 1.2.18 the issue magically has gone away. Same config, same cert.

@ProVega ProVega closed this as completed Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant